Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dims for Units waveform #1008

Merged
merged 2 commits into from
Jul 16, 2019
Merged

change dims for Units waveform #1008

merged 2 commits into from
Jul 16, 2019

Conversation

bendichter
Copy link
Contributor

add an optional 3D shape for waveform_mean and waveform_sd including a third dimension for electrodes

Motivation

You can easily put multi-electrode waveforms in the waveform_mean and waveform_sd columns, but it previously was not clear what the order of those dimensions was. This adds an optional 3D shape to waveform_mean and waveform_sd that puts electrodes in the last dimension

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ?

add an optional 3D shape for waveform_mean and waveform_sd including a third dimension for electrodes
@rly
Copy link
Contributor

rly commented Jul 9, 2019

Could you give an example use case for the new electrodes dimension?

@bendichter
Copy link
Contributor Author

It has come up several times that neurons are recorded from more than one electrode. Most recently with neuropixel data

@rly
Copy link
Contributor

rly commented Jul 10, 2019

Ah, thanks. Right. A unit recorded on multiple electrodes has a mean and sd waveform on each electrode, and it makes sense to store those.

@bendichter bendichter marked this pull request as ready for review July 16, 2019 21:15
@bendichter bendichter requested a review from rly July 16, 2019 21:15
@bendichter bendichter merged commit 12613e5 into dev Jul 16, 2019
@bendichter
Copy link
Contributor Author

@kristinquick this has been merged into dev

@rly rly deleted the waveform_dims branch July 16, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants