Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning with pkg_resources #1678

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Fix deprecation warning with pkg_resources #1678

merged 2 commits into from
Mar 24, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Mar 24, 2023

Motivation

Fix #1677

How to test the behavior?

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1678 (b2c8cd4) into dev (dd7d5a1) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev    #1678      +/-   ##
==========================================
- Coverage   91.99%   91.93%   -0.07%     
==========================================
  Files          26       26              
  Lines        2587     2592       +5     
  Branches      497      497              
==========================================
+ Hits         2380     2383       +3     
- Misses        132      134       +2     
  Partials       75       75              
Flag Coverage Δ
integration 71.52% <75.00%> (-0.03%) ⬇️
unit 83.56% <75.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/__init__.py 78.34% <75.00%> (-0.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly merged commit aaabb1f into dev Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DeprecationWarning: pkg_resources is deprecated as an API on =pynwb-2.3.1
2 participants