-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support stimulus_template as optional column in IntracellularRecordingsTable #1815
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## nwb-schema-2.7.0 #1815 +/- ##
====================================================
+ Coverage 91.99% 92.02% +0.03%
====================================================
Files 27 27
Lines 2623 2633 +10
Branches 685 690 +5
====================================================
+ Hits 2413 2423 +10
Misses 138 138
Partials 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good to me. I added a couple of comments for the tutorial part but those should be easy to fix.
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Looks good to me. @rly is doing a final review an will approve once ready. |
Co-authored-by: Ryan Ly <rly@lbl.gov>
@oruebel because you requested changes earlier, you still need to approve this |
Motivation
Fix #1747 to support
stimulus_template
as a predefined optional column of theIntracellularStimuliTable
(See NeurodataWithoutBorders/nwb-schema#545 for the related schema PR)
Since the proposed column neurodata type is
TimeSeriesReferenceVectorData
, I though it was maybe unclear how to add data to the column so I added an example in the tutorials.The
IntracellularRecordingsTable.add_recording
had some nice functionality to automatically compute the start_index and count values for stimulus time series inputs, as well as handle recordings with no stimulus info provided. I added similar behavior forstimulus_template
, but I'm not sure if that's something that would be helpful or if it's best to add additional stimulus template data via thestimulus_metadata
argumentHow to test the behavior?
Checklist
flake8
from the source directory.