TNM-4930 Added tests to validate serialized messages against 1.6 json… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinierl
approved these changes
Oct 16, 2017
build.sbt
Outdated
| val slf4jV = "1.7.12" | ||
|
|
||
| val json4sNative = "org.json4s" %% "json4s-native" % json4sV | ||
| val json4sjackson = "org.json4s" %% "json4s-jackson" % json4sV |
There was a problem hiding this comment.
Do we need this for some specific reason? Otherwise we could just as well import org.json4s.native.JsonMethods instead of org.json4s.jackson.JsonMethods, and get rid of one dependency.
|
the dependency on jackson is needed as the java json validator library uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… schema