This repository was archived by the owner on Jun 2, 2021. It is now read-only.
Update PostgreSQL plugin to work with PostgreSQL 9.6. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not well versed in Postgres, but this looks like it would be backwards comparable with older version as well correct? |
|
Yes, it's just a type cast to the type it was in older versions (TEXT), so should have no effect on older versions. |
Rockstar04
approved these changes
Mar 22, 2018
|
I see no reason not to merge this, it should function in any postgres version :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the PostgreSQL plugin fails because the fields like sent_location are now
pg_lsnrather than text fields, sosplit_partfails on them. We tested that the PostgreSQL plugin works without errors with this patch, but we did not have replication set up on those machines.