This repository was archived by the owner on Jun 2, 2021. It is now read-only.
rabbitmq: add timeouts so threads do not deadlock #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also modify exception handling so we fail immediately upon http failure
wolph
reviewed
Jun 22, 2018
| @@ -20,6 +20,7 @@ class RabbitMQ(base.Plugin): | |||
| DEFAULT_HOST = 'localhost' | |||
| DEFAULT_PORT = 80 | |||
| DEFAULT_API_PATH = '/api' | |||
| DEFAULT_TIMEOUT = (3.05, 30) | |||
There was a problem hiding this comment.
Perhaps a comment explaining that it's the connect timeout followed by the read timeout would be nice :)
And optionally a link to http://docs.python-requests.org/en/master/user/advanced/#timeouts as well
Rockstar04
approved these changes
Jun 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had situations (so far only in AWS) where things will get stuck waiting for one of these requests to fail, which it never does, because the default for requests is to wait forever. So, this adds support for timeouts and uses a reasonable default.