-
Notifications
You must be signed in to change notification settings - Fork 66
Feature: merge buy & edit cover in a single function and remove refund logic from Cover #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
401954d
to
6c7dc2c
Compare
6c7dc2c
to
66e04f3
Compare
Closed
danoctavian
reviewed
Nov 15, 2022
danoctavian
reviewed
Nov 15, 2022
|
||
function buyCover( | ||
BuyCoverParams memory params, | ||
PoolAllocationRequest[] memory allocationRequests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would rename this to poolAllocationRequests
The fact that there is another type called AllocationRequest makes it hard to disambiguate between what's coming from that array and what's being created inside the pool
danoctavian
reviewed
Nov 15, 2022
danoctavian
reviewed
Nov 15, 2022
b016a64
to
687223a
Compare
danoctavian
reviewed
Nov 15, 2022
danoctavian
reviewed
Nov 15, 2022
danoctavian
reviewed
Nov 15, 2022
4d406b5
to
2594ad8
Compare
0xdewy
reviewed
Nov 21, 2022
2594ad8
to
12d6cb3
Compare
12d6cb3
to
e17b751
Compare
Closed
6436d44
to
5083aaf
Compare
97cc567
to
4ca0cc9
Compare
5ca1c88
to
7d07dd4
Compare
9 tasks
roxdanila
approved these changes
Nov 24, 2022
9 tasks
roxdanila
added a commit
that referenced
this pull request
Nov 30, 2022
…e-and-edit Test: Fix remaining broken tests after PR #480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Partial implementation of #386.
Changes proposed in this pull request
buyCover
andeditCover
the PR merges them in a single functionCoverUtilsLib
toCover
contract:Test plan
All
buyCover
tests failed and need fixing (TBD).Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: