Test: Fix remaining broken tests after PR #480 #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxdanila
force-pushed
the
test/fix-tests-after-allocate-and-edit
branch
2 times, most recently
from
2aa56b1 to
387378a
Compare
roxdanila
force-pushed
the
test/fix-tests-after-allocate-and-edit
branch
from
33f03c8 to
7e76d45
Compare
roxdanila
commented
Nov 29, 2022
| } | ||
|
|
||
| uint coverAmountInCoverAsset = totalCoverAmountInNXM * nxmPriceInCoverAsset / ONE_NXM; | ||
| require(coverAmountInCoverAsset > 0, "Cover: Amount should be greater than 0"); |
There was a problem hiding this comment.
Added this check that was missing previously. Bug found via a test.
Closed
Closed
danoctavian
reviewed
Nov 29, 2022
danoctavian
reviewed
Nov 29, 2022
roxdanila
force-pushed
the
test/fix-tests-after-allocate-and-edit
branch
from
912dc06 to
f124f42
Compare
roxdanila
force-pushed
the
test/fix-tests-after-allocate-and-edit
branch
from
c54ab16 to
c8c97ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
PR #480 introduced multiple test failures that were not addressed as we wanted to merge early to unblock other contributors. This PR addresses them.
Changes proposed in this pull request
A bunch of tests are still skipped - they are to do with the logic related to edit cover (still being finalized) and expire cover (to be implemented using buckets).
Test plan
Ran all tests.
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: