Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of WorkflowExecutorListener.handlePotentiallyStuck #391

Merged
merged 11 commits into from
Apr 18, 2020
Merged

Support of WorkflowExecutorListener.handlePotentiallyStuck #391

merged 11 commits into from
Apr 18, 2020

Conversation

efonsell
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 18, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 84.946% when pulling eb12602 on stuck-handler into 3157162 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.942% when pulling 2959f0f on stuck-handler into be52712 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.942% when pulling 2959f0f on stuck-handler into be52712 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.942% when pulling 2959f0f on stuck-handler into be52712 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.942% when pulling 2959f0f on stuck-handler into be52712 on master.

@efonsell efonsell force-pushed the stuck-handler branch 2 times, most recently from 7d638f4 to 261847c Compare April 18, 2020 16:01
@efonsell efonsell merged commit a6bce76 into master Apr 18, 2020
@efonsell efonsell deleted the stuck-handler branch April 18, 2020 21:06
efonsell added a commit that referenced this pull request Apr 19, 2020
@efonsell @gmokki
Support of WorkflowExecutorListener.handlePotentiallyStuck (#391)
e61333b 
* make test more robust

* Support of WorkflowExecutorListener.handlePotentiallyStuck

* refactor

* Unwrap the real exception from UndeclaredThrowableException

* Test reliably that the interruption of a workflow worked correctly

* method ref and assertFalse

* add entry to changelog

* fix changelog

* remove unnecessary lenient

* Update CHANGELOG.md

* pass ListenerContext to handlePotentiallyStuck

Co-authored-by: Edvard Fonsell <edvard.fonsell@nitorcreations.com>
Co-authored-by: Mikko Tiihonen <gmokki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmokki gmokki gmokki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efonsell @coveralls @gmokki