Use Nix's SSHMaster
#1339
Merged
Use Nix's SSHMaster
#1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
use-nix-ssh
branch
from
c75e0be
to
a65e391
Compare
Ericson2314
force-pushed
the
use-nix-ssh
branch
from
a65e391
to
7386caa
Compare
13 tasks
|
This introduces a regression for machine definitions that have an SSH hostkey specified, because it gets base64 decoded in hydra, then passed to SSHMaster in nix which wants to base64 decode it again. Fix applied for h.n.o is 031aaa0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this doesn't work yet.
Depends on NixOS/nix#9833