Generalize recognized git url schemas (#13925)

twesterhout · web-flow · commit dbc235cc62b0 · 2025-09-07T15:22:20.000+02:00
Use `parseUrlScheme` instead of manually parsing `url.scheme`.
diff --git a/src/libfetchers/git.cc b/src/libfetchers/git.cc
@@ -163,8 +163,8 @@ struct GitInputScheme : InputScheme
 {
     std::optional<Input> inputFromURL(const Settings & settings, const ParsedURL & url, bool requireTree) const override
     {
-        if (url.scheme != "git" && url.scheme != "git+http" && url.scheme != "git+https" && url.scheme != "git+ssh"
-            && url.scheme != "git+file")
+        auto parsedScheme = parseUrlScheme(url.scheme);
+        if (parsedScheme.application != "git")
             return {};
 
         auto url2(url);

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,8 @@ struct GitInputScheme : InputScheme`
`163`	`163`	`{`
`164`	`164`	`std::optional<Input> inputFromURL(const Settings & settings, const ParsedURL & url, bool requireTree) const override`
`165`	`165`	`{`
`166`		`- if (url.scheme != "git" && url.scheme != "git+http" && url.scheme != "git+https" && url.scheme != "git+ssh"`
`167`		`- && url.scheme != "git+file")`
	`166`	`+ auto parsedScheme = parseUrlScheme(url.scheme);`
	`167`	`+ if (parsedScheme.application != "git")`
`168`	`168`	`return {};`
`169`	`169`
`170`	`170`	`auto url2(url);`