Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The progress-bar data indicator doesn't update for nix copy #8000

Closed
thufschmitt opened this issue Mar 8, 2023 · 0 comments · Fixed by #8015
Closed

The progress-bar data indicator doesn't update for nix copy #8000

thufschmitt opened this issue Mar 8, 2023 · 0 comments · Fixed by #8015
Labels
bug

Comments

@thufschmitt
Copy link
Member

thufschmitt commented Mar 8, 2023 •
edited
Loading

Split out of #7959 since the original one was mentioning two separate issues

Describe the bug

[When running nix-copy], the progress status does not show the size of file that has been uploaded, users would be confused when uploading a large store path, thinking that there is no progress at all (but it is actually uploading).

termtosvg_k3uwuepz

Steps To Reproduce

$ fallocate -l 1GiB 1GbFile 
$ nix store add-file ./1GbFile                                                   
/nix/store/j73ps3ak1bwd99dbrqpyc4kmsn9xp3di-1GbFile
$ nix copy --to /tmp/nixstore /nix/store/j73ps3ak1bwd99dbrqpyc4kmsn9xp3di-1GbFile
# wait

Expected behavior

The progress-bar should cleanly upgrade as data is transferred to the destination store

Priorities

Add 👍 to issues you find important.

/cc @balsoft @Ninlives
@thufschmitt thufschmitt added the bug label Mar 8, 2023
balsoft added a commit to serokell/nix that referenced this issue Mar 9, 2023
@balsoft
Display progress when running copyPaths (nix copy)
4bef201 
`nix copy` operations did not show progress. This is quite confusing.

Add a `progressSink` which displays the progress during `copyPaths`,
pretty much copied from `copyStorePath`.

Fixes NixOS#8000
This was referenced Mar 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@thufschmitt