Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the run and shell envs for stray variables #10931

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Jun 17, 2024

Motivation

Test an important property of the nix run and nix shell commands.

Context

Originally written for #10879, which needed to set a variable temporarily.
The need to check this may arise from a different change in the future.

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@roberth roberth added the tests label Jun 17, 2024
@roberth roberth requested a review from edolstra as a code owner June 17, 2024 15:08
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jun 17, 2024
@edolstra edolstra merged commit 05751de into NixOS:master Jul 17, 2024
10 checks passed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-07-17-nix-team-meeting-minutes-162/49255/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests with-tests Issues related to testing. PRs with tests have some priority
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants