Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix profile: add aliases #4961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ethancedwards8
Copy link
Member

This PR adds aliases to the nix profile subcommand, which I think are helpful and I was surprised aren't there already.

A case can be made for aliases for install or upgrade, but I think for right now only having them for list and remove is fine.

@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Jun 29, 2021

Works and builds on MacOS M1 using Rosetta.

@ethancedwards8
Copy link
Member Author

ethancedwards8 commented Jun 29, 2021

Works and builds on x86_64 NixOS Linux.

@edolstra edolstra added improvement UX The way in which users interact with Nix. Higher level than UI. labels Jun 30, 2021
@edolstra
Copy link
Member

edolstra commented Jul 5, 2021

I'm not convinced this is a good idea. If the goal is to reduce typing, I think tab completion is good enough for that. And adding aliases pollutes the search space for tab completion.

If we do decide to add aliases, we should have some guidance in doc/manual/src/contributing/cli-guideline.md on when to add an alias.

BTW, I think implemented like this, the manual pages will be duplicated for each alias.

@ethancedwards8
Copy link
Member Author

I'm not convinced this is a good idea. If the goal is to reduce typing, I think tab completion is good enough for that. And adding aliases pollutes the search space for tab completion.

IMO the goal was less to "reduce typing" and more "conform to traditional standards".

If we do decide to add aliases, we should have some guidance in doc/manual/src/contributing/cli-guideline.md on when to add an alias.

BTW, I think implemented like this, the manual pages will be duplicated for each alias.

Yes I believe that is so.

One option I have thought about is creating an option for aliases in nix.conf, that way man pages will not be cluttered, and it gives the end user more fine grain control.

@ethancedwards8
Copy link
Member Author

Is this still open for discussion?

@stale
Copy link

stale bot commented Apr 16, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot removed the stale label Dec 5, 2022
@Ericson2314 Ericson2314 added the new-cli Relating to the "nix" command label Jun 14, 2023
@edolstra edolstra self-requested a review as a code owner November 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-cli Relating to the "nix" command UX The way in which users interact with Nix. Higher level than UI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants