Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace defaultBla.$system with bla.$system.default #6089

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Feb 11, 2022

This also simplifies some InstallableFlake logic and fixes nix bundle parsing its installable twice.

Fixes #5532.

TODO

  • make nix flake check warn about the old defaultX outputs.
  • update documentation
  • release note (bonus for examples)

This also simplifies some InstallableFlake logic and fixes 'nix
bundle' parsing its installable twice.

Fixes NixOS#5532.
@edolstra edolstra marked this pull request as ready for review February 22, 2022 13:33
@edolstra edolstra merged commit 5968373 into NixOS:master Feb 24, 2022
@edolstra edolstra deleted the dot-default branch February 24, 2022 20:17
@tomberek tomberek mentioned this pull request Mar 12, 2022
@Pacman99
Copy link

Pacman99 commented Mar 13, 2022

How come this doesn't change nixosModule to nixosModules.default? Thats similar enough to overlay since their both not system-spaced and nix functions, but only overlay was changed.

@rehno-lindeque
Copy link
Contributor

I have the same question. I think a nice pattern for many people would be:

nixosModules = rec {
  default = {
    imports = [
      moduleA
      moduleB
      moduleC
    ];
  };
  moduleA = import ./nixos-modules/module-a;
  moduleB = import ./nixos-modules/module-b;
  moduleC = import ./nixos-modules/module-c;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename defaultX flake outputs to X.default
4 participants