add descriptive output when creating templates #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this includes a `welcomeText` attribute which can be set in the template, as well as outputing which files were created.
|
I think the |
roberth
reviewed
Feb 17, 2022
src/nix/flake-init.md
Outdated
| @@ -45,6 +49,10 @@ outputs = { self }: { | |||
| templates.rust = { | |||
| path = ./rust; | |||
| description = "A simple Rust/Cargo project"; | |||
| welcomeText = '' | |||
| You've created a simple Rust/Cargo template. | |||
| Visit https://www.rust-lang.org/ for more info. | |||
There was a problem hiding this comment.
I don't think this is a useful link. It should point to a Nix-specific document.
I understand that it's just an example, but we shouldn't set a wrong precedent.
There was a problem hiding this comment.
let me know if it's better now
jian-lin
added a commit
to linj-fork/nix
that referenced
this pull request
Nov 21, 2023
This number is not updated when welcomeText is added[1][2]. [1]: f3a2940 [2]: NixOS#6103
jian-lin
added a commit
to linj-fork/nix
that referenced
this pull request
Nov 21, 2023
This number is not updated when welcomeText is added[1][2]. [1]: f3a2940 [2]: NixOS#6103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this includes a
welcomeTextattribute which can be set in thetemplate, as well as outputing which files were created.
#4503