Enforce a global "offline" setting #6252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
suggested changes
Mar 14, 2022
|
BTW, I'd like the offline flag/setting to make all caches valid rather than stale to fix #2022, but that can be a seperate PR. |
thufschmitt
suggested changes
Apr 14, 2022
There was a problem hiding this comment.
A few comments but looks good overall.
There’s also a few places where the cache still can expire in offline mode, I guess that’s what you meant to add as a follow-up in #6252 (comment)
Ericson2314
reviewed
Jun 23, 2023
|
Draft because changes requested. |
github-actions
bot
added
fetching
Do not attempt to fetch anything when the "--offline" flag is passed on the command line or when "offline" is set to true in a configuration file.
|
I should point out that I don't see any way to guarantee that an offline flag is being enforced everywhere. I'm probably missing some cases and it would be an iterative process to fully implement this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attempt to fetch anything when the "--offline" flag is
passed on the command line or when "offline" is set to true in
a configuration file.