Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfetchers/git: add missing --git-dir flags #6643

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

ncfavier
Copy link
Member

@ncfavier ncfavier commented Jun 10, 2022

Fixes #6636, fixes #6443 again.

This was previously fixed by #6440, but the fix was lost when merging #4638 due to conflicting edits in src/libfetchers/git.cc.

Confirmed that this also fixes fetching flake inputs owned by another user NixOS/nixpkgs#169193 (comment)

@Ma27
Copy link
Member

Ma27 commented Jun 10, 2022

cc @edolstra @thufschmitt @orbekk

Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully that one will be the good one 🤞🏻

@github-actions
Copy link

Successfully created backport PR #6644 for 2.9-maintenance.

@Ma27
Copy link
Member

Ma27 commented Jun 13, 2022

@thufschmitt @edolstra I guess it's reasonable to make a 2.9.1 with this change bneing backported :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants