-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchGit: allow fetching annotated tags #6766
base: master
Are you sure you want to change the base?
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-01-20-nix-team-meeting-minutes-25/25432/1 |
After digging a bit into that, it turns out that the thing that matters is that annotated tags aren't commits (they are their own thing), and Git doesn't allow writing something that's not a commit hash under And obviously: Can you add some tests for this? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-12-nix-team-meeting-minutes-62/29315/1 |
Git doesn't like pointing a branch ref to an annotated tag, however the other way around is fine. Use this to allow fetchGit to fetch annotated tags, without specifically annotating them as such.
daba899
to
2f21197
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-10-02-nix-team-meeting-minutes-183/53815/1 |
Git doesn't like pointing a branch ref to an annotated tag, however the
other way around is fine. Use this to allow fetchGit to fetch annotated
tags, without specifically annotating them as such.
(hopefully) fixes #3701
Please review with care! I'm not sure this doesn't break some important assumption elsewhere.
Tested by poking around locally.