Make 'logger' a std::unique_ptr #6962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents it from being leaked (see bb411e4 for an example of this).
Ericson2314
reviewed
Aug 30, 2022
| @@ -110,7 +105,7 @@ namespace nix { | |||
| CaptureLogging l; | |||
| auto v = eval("builtins.trace \"test string 123\" 123"); | |||
| ASSERT_THAT(v, IsIntEq(123)); | |||
| auto text = l.get(); | |||
| auto text = ((CaptureLogger *) logger.get())->get(); | |||
Ericson2314
approved these changes
Aug 30, 2022
Ericson2314
added
the
contributor-experience
|
Triaged in the Nix team meeting:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-03-03-nix-team-meeting-minutes-37/25998/1 |
|
@edolstra do you want to take another look at it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents it from being leaked (see bb411e4 for an example of this).
This also fixes a bug in the ProgressBar destructor when isTTY = false.