check the store for input before failing (hopefully fix #6700) #7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radvendii
changed the title
|
Good catch @thufschmitt . Fixed it in the commit message and the PR title but not the branch name. I don't think that will show up anywhere once merged, right? |
It'll probably still show-up somewhere, but not as visibly as the rest, so it should be good 👍 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-41/23848/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix very similar to #7283 but in a slightly different place, which will hopefully address #6700. I can't reproduce the issue, so I'm not sure it fixes it.
The idea is that
inputDrvOutputsis statefully constructed and is somehow not getting set properly. Rather than track down that bug (which would also be good to do at some point), this piece of duct-tape just checks the actual store as a backup wheninputDrvOutputsdoesn't have it.