Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user instead of warning them when using a trusted substituter #7462

Conversation

rapenne-s
Copy link
Member

When an user is trusted by nix and has accepted a substituter, there is
a Warning message in fuschia displayed at each use of this substituter
because it's trusted.

This change the behavior by downgrading the message at the info level,
only displayed with nix in verbose mode.

This is actually scaring people because it looks like a problem, while
it's just plain information about something they did.

@rapenne-s rapenne-s marked this pull request as ready for review December 14, 2022 13:13
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/what-would-you-like-to-see-improved-in-nix-cli-experience/24012/1

Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fair (with just a minor nitpick because it's nicer that way), there's no real need to display this every time.

src/libexpr/flake/config.cc Outdated Show resolved Hide resolved
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
@domenkozar domenkozar merged commit f118e66 into NixOS:master Dec 19, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-42/24204/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-team-report-2022-10-2023-03/27486/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants