Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: builtins.fetchGit when used on a local path #7706

Merged
merged 3 commits into from
Feb 8, 2023

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Jan 28, 2023

fixes #2936

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor language suggestions. Thanks, that's valuable documentation.

src/libexpr/primops/fetchTree.cc Outdated Show resolved Hide resolved
src/libexpr/primops/fetchTree.cc Outdated Show resolved Hide resolved
src/libexpr/primops/fetchTree.cc Outdated Show resolved Hide resolved
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
@nomeata
Copy link
Contributor Author

nomeata commented Feb 8, 2023

Thanks, applied

@fricklerhandwerk fricklerhandwerk enabled auto-merge (squash) February 8, 2023 11:16
@fricklerhandwerk fricklerhandwerk merged commit e4a2a5c into NixOS:master Feb 8, 2023
@nomeata nomeata deleted the joachim/fix2936 branch February 8, 2023 12:30
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-44/25546/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document builtins.fetchGit when used on a local path
3 participants