Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: Ask release notes for incompatible changes, not bug fixes #7780

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Feb 7, 2023

Motivation

We never mention bug fixes in the release notes, but we should include incompatible changes.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

@edolstra edolstra merged commit fd01b8f into NixOS:master Feb 7, 2023
@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Feb 10, 2023

I think this should have been discussed on the team.
It's true that we don't currently write release note about bug fixes, but there may be good reasons to start doing so.
Whatever we decide, we should at least provide a reason why we do it that way.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-44/25546/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants