-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix nix-shell commands #7849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
This whole example should probably not even be here, because all of it is specific to Nixpkgs. I'll merge this for the example to be correct, but eventually it should find a new home in the Nixpkgs manual.
Would be great if you could take the time to make a PR there and ping me.
IMHO since this is a specific example, it doesn't have to be generic. E.g. if Pan doesn't have a patchPhase, then there is no need to run the patchPhase. @fricklerhandwerk I don't think it's a problem that it's specific to Nixpkgs, since that's what everybody uses. ( |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-44/25546/1 |
@edolstra I still think we should just remove that part here because it doesn't really help at this point. I also fear the entangling may actually get worse by codifying it in documentation. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-03-31-nix-team-meeting-minutes-45/27002/1 |
Discussed in the Nix team meeting 2023-04-03:
|
04c4c5d
to
1ac1080
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-04-03-nix-team-meeting-minutes-46/27008/1 |
generalize example commands for nix-shell
why
im using
man nix-shell
as a cheatsheet for${patchPhase:-patchPhase}
was missingcd $sourceRoot
is more genericChecklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*