Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect allRefs=1 when using nix flake prefetch #8050

Merged
merged 1 commit into from
Mar 15, 2023
Merged

respect allRefs=1 when using nix flake prefetch #8050

merged 1 commit into from
Mar 15, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Mar 15, 2023

Motivation

So out of tree revisions can be fetched with nix flake prefetch by using allRefs=1 as a query parameter

Context

Makes it possible to work around #5128 when using nix flake prefetch

Here is an example that works after this change:

nix flake prefetch --extra-experimental-features "nix-command flakes" git+https://github.com/fdehau/tui-rs?allRefs=1&rev=6f4831a769d7adead8c53986cc2255e61c283e70

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@figsoda figsoda requested a review from edolstra as a code owner March 15, 2023 15:35
@edolstra edolstra merged commit 1b8c13c into NixOS:master Mar 15, 2023
@figsoda figsoda deleted the allrefs branch March 15, 2023 16:58
figsoda added a commit to nix-community/nurl that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants