-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetchers: Try to substitute if curl fails. #8184
base: master
Are you sure you want to change the base?
Conversation
f3a112c
to
e324ee4
Compare
e324ee4
to
4e9b774
Compare
7c003f5
to
fbc41fa
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-31-nix-team-meeting-minutes-76/31486/1 |
Looks like this needs a rebase. Woops! Sorry! |
fbc41fa
to
6818bb2
Compare
Ok, rebased. I confirmed |
@edolstra Just a ping (sorry). Do you have thoughts about the urls returned when substitutes are tried? |
throw; | ||
} | ||
|
||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit is what I know least about.
Motivation
Fetchers currently do not try to substitute if downloading via curl fails and there is no cached result.
This is important if using flakes or fetchers in an tightly controlled environment.
Context
Fixes #4313
For performance reasons - only try to substitute when there is an error during curl.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.