-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make print-build-logs a setting #8323
base: master
Are you sure you want to change the base?
Conversation
This allows you to put `print-build-logs = true` in nix.conf. Issue NixOS#5858.
Adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone who tried to get something very similar in before (but much more wide-reaching: #3961), I'd be very very happy to see this merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a
log-format
setting is slightly trickier, since the old and new CLI have different defaults.
Can't we just agument a enum with an extra case "default", which keeps the current per-CLI defaults?
I would rather have that than the print-build-logs
setting.
Yeah just make it |
It's not that easy, because setting |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-02-nix-team-meeting-minutes-59/28666/1 |
This PR needs a rebase, but is there anything else blocking it? |
Motivation
This allows you to put
print-build-logs = true
in nix.conf. It also implicitly adds--no-print-build-logs
.Context
Issue #5858.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.