Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball trees: Propagate lastModified #8859

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Aug 22, 2023

Motivation

This makes tarball flakes behave consistently with GitHub/GitLab flakes, e.g. it makes

nix flake metadata https://github.com/NixOS/nix/archive/2.17.0.zip

return the same "Last modified" value as

nix flake metadata github:NixOS/nix/2.17.0

which is important for flakes that depend on lastModified to evaluate consistently.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@github-actions github-actions bot added with-tests Issues related to testing. PRs with tests have some priority fetching Networking with the outside (non-Nix) world, input locking labels Aug 22, 2023
This makes them behave consistently with GitHub/GitLab flakes.
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, I didn't realize the tarball + github flakes differed in this way. This was already in the --json output, so I suppose it's nice to have it in the user-friendly-er output too.

@edolstra edolstra merged commit 5b5f56a into NixOS:master Aug 29, 2023
8 checks passed
@edolstra edolstra deleted the tarball-last-modified branch August 29, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world, input locking with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants