Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDPAU_DRIVER broken for NVIDIA + Intel CPU #388

Closed
bbigras opened this issue Mar 7, 2022 · 3 comments · Fixed by #389
Closed

VDPAU_DRIVER broken for NVIDIA + Intel CPU #388

bbigras opened this issue Mar 7, 2022 · 3 comments · Fixed by #389

Comments

@bbigras
Copy link
Contributor

bbigras commented Mar 7, 2022

since 1da3ba1, Chrome doesn't start anymore. See NixOS/nixpkgs#162499

Should common/gpu/nvidia.nix just set VDPAU_DRIVER to nvidia?

@ilkecan

@ilkecan
Copy link
Member

ilkecan commented Mar 7, 2022

Assuming setting an environment variable like VDPAU_DRIVER is within the scope of this project, I think what you propose is the correct solution. Since nvidia is the default value, it should have priority over the mkDefault in the intel module, so something like mkOverride 900 "nvidia" could be used.

Also it might be a good idea to split the graphics related parts of common/cpu/intel.nix into a new file named common/gpu/intel.nix.

@06kellyjac
Copy link
Member

Just for my sake, where is VDPAU_DRIVER's default set to nvidia?


As for your comment both changes sounds good

@ilkecan
Copy link
Member

ilkecan commented Mar 7, 2022

VDPAU_DRIVER is not set by default. In my experience the driver used defaults to nvidia when the environment variable is not set. I found this reasonable considering VDPAU was created by NVIDIA, so I didn't look into it further.

bbigras added a commit to bbigras/nixos-hardware that referenced this issue Mar 7, 2022
bobvanderlinden added a commit to bobvanderlinden/nixos-config that referenced this issue Mar 10, 2022
bbigras added a commit to bbigras/nixos-hardware that referenced this issue Apr 9, 2022
bbigras added a commit to bbigras/nixos-hardware that referenced this issue Apr 12, 2022
bbigras added a commit to bbigras/nixos-hardware that referenced this issue Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants