Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yuzu-{mainline,ea}: {517,1377} -> {546,1480} #113949

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Feb 21, 2021

Motivation for this change

cc @aanderse :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 21, 2021

Result of nixpkgs-review pr 113949 at f7159cd8 run on aarch64-linux 1

2 packages failed to build:

Result of nixpkgs-review pr 113949 at f7159cd8 run on x86_64-linux 1

1 package failed to build:
1 package built:

@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Feb 23, 2021

I've just updated this to include version info at runtime, which previously did not work.
Relevant issue: #114044

Thank you @JoshuaFern for noticing this! I had no idea as I do not have titlebars in my WM.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113949 run on x86_64-linux 1

2 packages built:
  • yuzu-ea
  • yuzu-mainline

@SuperSandro2000 SuperSandro2000 merged commit 8ac27aa into NixOS:master Feb 23, 2021
@IvarWithoutBones IvarWithoutBones deleted the yuzu-update branch August 30, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants