-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spotify-unwrapped: 1.1.46.916.g416cacf1 -> 1.1.55.494.gca75f788 #116805
spotify-unwrapped: 1.1.46.916.g416cacf1 -> 1.1.55.494.gca75f788 #116805
Conversation
Result of 3 packages built successfully:
1 suggestion:
|
Thanks @r-rmcgibbo for the suggestion! I fixed it in 3b84765. The new version wasn't running for me so I fixed (what I believe to be) all the dependency issues in 78d3a4b. |
}; | ||
|
||
nativeBuildInputs = [ makeWrapper ]; | ||
buildInputs = [ squashfsTools ]; | ||
nativeBuildInputs = [ makeWrapper squashfsTools ]; | ||
|
||
dontStrip = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does stripping break it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. This was just the suggestion in @r-rmcgibbo's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I just realized you commented on line 87, not 84-85... That's a great question re dontStrip
. That decision was before my time... Perhaps one of the maintainers would know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. This was already included in the original commit (f81bc24). I'd say there is a good chance that it is not needed (anymore). I think we should generally not require unrelated improvements on update PRs though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd be happy to submit a follow-up PR removing dontStrip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't need it?
dontStrip = true; |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! I won't merge this yet because I don't want to step over @SuperSandro2000 regarding the dontStrip
thread. In my opinion it is good to go though.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
Upgrades spotify-unwrapped from 1.1.46.916.g416cacf1 to 1.1.55.494.gca75f788
This PR was automatically generated by nixpkgs-upkeep.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)