Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify-unwrapped: 1.1.46.916.g416cacf1 -> 1.1.55.494.gca75f788 #116805

Conversation

samuela
Copy link
Member

@samuela samuela commented Mar 19, 2021

Motivation for this change

Upgrades spotify-unwrapped from 1.1.46.916.g416cacf1 to 1.1.55.494.gca75f788

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: 96fe581eb7f2ba2387b11e0da5dec28e.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 19, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116805 at de7418b run on x86_64-linux 1

3 packages built successfully:
1 suggestion:
  • warning: build-tools-in-build-inputs

    squashfsTools is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/audio/spotify/default.nix:85:3:

       |
    85 |   buildInputs = [ squashfsTools ];
       |   ^
    

@samuela
Copy link
Member Author

samuela commented Mar 19, 2021

Thanks @r-rmcgibbo for the suggestion! I fixed it in 3b84765.

The new version wasn't running for me so I fixed (what I believe to be) all the dependency issues in 78d3a4b.

};

nativeBuildInputs = [ makeWrapper ];
buildInputs = [ squashfsTools ];
nativeBuildInputs = [ makeWrapper squashfsTools ];

dontStrip = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does stripping break it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. This was just the suggestion in @r-rmcgibbo's comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I just realized you commented on line 87, not 84-85... That's a great question re dontStrip. That decision was before my time... Perhaps one of the maintainers would know?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This was already included in the original commit (f81bc24). I'd say there is a good chance that it is not needed (anymore). I think we should generally not require unrelated improvements on update PRs though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd be happy to submit a follow-up PR removing dontStrip

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't need it?

Suggested change
dontStrip = true;

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116805 run on x86_64-linux 1

3 packages built:
  • spotify
  • spotify-unwrapped
  • spotifywm

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I won't merge this yet because I don't want to step over @SuperSandro2000 regarding the dontStrip thread. In my opinion it is good to go though.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/360

@SuperSandro2000 SuperSandro2000 merged commit f8043eb into NixOS:master Mar 25, 2021
@samuela samuela deleted the upkeep-bot/spotify-unwrapped-1.1.55.494.gca75f788-1616113183 branch March 25, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants