freenet: rewrite wrapper to not depend on PATH

[VShell]

Rewrite wrapper depended on $PATH containing bash and coreutils, so I've merged the wrapper and run script together and ensured that they don't. Can @spacekitteh test this, I've so far only tested that it starts.

[mention-bot]

By analyzing the blame information on this pull request, we identified @doublec, @viric and @edolstra to be potential reviewers

[spacekitteh]

how to test it?

[doublec]

I can test but the original was working for me. I'll report back here shortly if things still work. Basic steps are run freenet:

$ freenet

Then visit http:/127.0.0.1:8888 in the browser and see if it shows the freenet installation wizard.

[spacekitteh]

No I mean, how to grab this specific pull request and install it

[VShell]

@doublec I believe @spacekitteh was trying to run it under systemd, I assume as part of NixOS.

@spacekitteh I think, assuming you have Freenet as a systemd service somewhere in your config:

git clone --depth 1 https://github.com/VShell/nixpkgs.git
NIX_PATH=nixpkgs=`pwd`/nixpkgs nixos-rebuild switch

Should do it.

[doublec]

Seems broken with this commit. After installation running freenet fails due to freenet_jars not being substituted in the freenet script. It looks like this should be freenet inside freenetWrapper, not freenet-jars. If I replace that, reinstall, then it runs and works fine.

[VShell]

@doublec Fixed, sorry about that.

[doublec]

Thanks, I confirm that works running freenet standalone. I don't know how to get it running as a systemd service on NixOS but if someone can provide pointers I can test that.

[peti]

The diff of the section above looks really strange. What is going on there? Did you add tabs, maybe?

Generally speaking, please don't commit white-space changes as those make the diffs unnecessarily long and hard to read.

[VShell]

What I've done here is moved a "base" derivation into the let block, and the main derivation is a wrapper around that. I've since figured out a way I can merge them into one derivation again by using substituteAll from stdenv directly, which I will probably do this evening, which would clear up the diff a lot.

[jagajaga]

Ping