vscode-extensions: remote-ssh acquires user's home directory from $HOME

[iosmanthus]

Signed-off-by: iosmanthus myosmanthustree@gmail.com

Motivation for this change

vscode-extensions.ms-vscode-remote.remote-ssh won't work while I try to login to a NixOS host as a root user. (homed in /root). This patch fixes the home mismatch while enabled userLocalExtensions in vscode-extensions.ms-vscode-remote.remote-ssh via $HOME

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 122595 at 4474402 run on x86_64-linux 1

1 package built successfully:

• vscode-extensions.ms-vscode-remote.remote-ssh

3 suggestions:

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/misc/vscode-extensions/vscode-utils.nix:21:12:

     |
  21 |     inherit configurePhase buildPhase dontPatchELF dontStrip;
     |            ^
  

• warning: build-tools-in-build-inputs

  unzip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/misc/vscode-extensions/vscode-utils.nix:25:5:

     |
  25 |     buildInputs = [ unzip ] ++ buildInputs;
     |     ^
  

• warning: missing-phase-hooks

  configurePhase should probably contain runHook preConfigure and runHook postConfigure.

  Near pkgs/misc/vscode-extensions/vscode-utils.nix:21:12:

     |
  21 |     inherit configurePhase buildPhase dontPatchELF dontStrip;
     |            ^
  

[iosmanthus]

PTAL @tbenst

[tbenst]

LGTM