Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alttpr-opentracker: init at 1.8.2 #142919

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

A pretty nice A Link to the Past Randomizer tracker. Previously packaged in #106789, but now build from source :)

Sadly the UI library seems to be using some fetched SO's, so we still need to patchelf this.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 142919 run on x86_64-linux 1

1 package built:
  • alttpr-opentracker

@SuperSandro2000 SuperSandro2000 merged commit a2ab553 into NixOS:master Oct 26, 2021
@IvarWithoutBones IvarWithoutBones deleted the init/opentracker branch October 26, 2021 16:00
@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Jan 12, 2022

@ofborg eval

Trying to see if this fails on darwin, but I don't think i have perms to do that :(

@winterqt
Copy link
Member

@ofborg eval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants