-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pkgs aliases #14398
Remove pkgs aliases #14398
Conversation
/participate |
Can we come up with a test that will check this is true for future commits? |
@domenkozar Yes, my initial plan was to use the static analysis to ensure that the number issues does not grow. But we can only do that as soon as #10851 is landed, and as soon as the number of issues is low (no bad idioms remain). |
Those changes seem both trivial (and shouldn't change hashes if I understand correctly) and affecting fast-moving target ( |
Fix conflicts: - add liquibase near llvm attributes. - Merge flashplayer-standalone-debugger expression.
…rriden packages. (cherry picked from commit 5c6bcee) There weres some conflicts, I fixed them.
This branch aims at keeping the same hashes, but only removing aliases reported by the static analysis added in #10851 .
This branch aims at solving one of the problem which should be fixed to make the #10851 hypothesis hold, which is that all packages are defined in the first "generation" of Nixpkgs evaluation.
Thus transforming the following attribute accesses:
Into something like:
These changes are likely to bit-rot over time, thus this pull request is a meta issue / staging area for patches which are pending for review.
cc @edolstra
update: rephrase, to make statements clearer