Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for static builds #144207

Closed
KAction opened this issue Nov 2, 2021 · 3 comments
Closed

CI for static builds #144207

KAction opened this issue Nov 2, 2021 · 3 comments
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: static

Comments

@KAction
Copy link
Contributor

KAction commented Nov 2, 2021

I fixed static build of opens in [4879ea9], but as of [31b4955] it is broken again:

...
/nix/store/syy77y0g93whfm2q7vawcgcjby41kwcm-x86_64-unknown-linux-musl-binutils-2.35.1/bin/x86_64-unknown-linux-musl-ld: /nix/store/82y864wrlmlqkw3mmydpkwp20gv0mnqa-libkrb5-1.18-x86_64-u
nknown-linux-musl/lib/libkrb5.a(cc_keyring.o): in function `krcc_generate_new':
/nix/store/syy77y0g93whfm2q7vawcgcjby41kwcm-x86_64-unknown-linux-musl-binutils-2.35.1/bin/x86_64-unknown-linux-musl-ld: /nix/store/82y864wrlmlqkw3mmydpkwp20gv0mnqa-libkrb5-1.18-x86_64-u
nknown-linux-musl/lib/libkrb5.a(cc_keyring.o): in function `krcc_generate_new':
(.text+0x1f00): undefined reference to `keyctl_search'
(.text+0x1f00): undefined reference to `keyctl_search'
/nix/store/syy77y0g93whfm2q7vawcgcjby41kwcm-x86_64-unknown-linux-musl-binutils-2.35.1/bin/x86_64-unknown-linux-musl-ld: (.text+0x1f8a): undefined reference to `add_key'
/nix/store/syy77y0g93whfm2q7vawcgcjby41kwcm-x86_64-unknown-linux-musl-binutils-2.35.1/bin/x86_64-unknown-linux-musl-ld: (.text+0x1f8a): undefined reference to `add_key'
collect2: error: ld returned 1 exit status
collect2: error: ld returned 1 exit status
make: *** [Makefile:210: ssh] Error 1
make: *** [Makefile:210: ssh] Error 1
builder for '/nix/store/mwnjzygh8mzw5ils01prfkirbfn8wq16-openssh-static-x86_64-unknown-linux-musl-8.7p1.drv' failed with exit code 2

There was quite a refactoring of openssh, according to git-blame, and I am still bisecting it. I'll probably fix it in weeks coming, but real question is to how to make fixed stuff fixed.

As I understand, static builds are not really checked by Hydra, in particular because unknown subset of them actually works.

So here I come with proposal -- export packages that are known to build statically as "static-foo" (subject to bike shedding)
in top-level/all-packages.nix, so we keep track of what is supposed to work and can check whether any particular patch broke it.

Opinions? Better proposals?

@KAction KAction added the 0.kind: bug Something is broken label Nov 2, 2021
@roberth
Copy link
Member

roberth commented Nov 2, 2021

I'd like for the top-level fixpoint (aka pkgs) to remain conceptually simple and relying on non-strictness to work, without prescribing what can not be done, even if that's implicit.
Instead we can add to pkgs/top-level/release.nix to describe what is known to work and therefore should keep working.
This is to the degree that the community can realistically support this of course. Perhaps that expression could alter the meta to set or add specific maintainers to individual packages.
Currently only stdenv is listed.

@jonringer
Copy link
Contributor

add a passthru.tests.static = pkgsStatic.openssl would probably help. At least ofborg would at least error if the build broke.

KAction pushed a commit to KAction/nixpkgs that referenced this issue Nov 4, 2021
SuperSandro2000 pushed a commit that referenced this issue Nov 5, 2021
Co-authored-by: Dmitry Bogatov <git#v1@kaction.cc>
@stale
Copy link

stale bot commented May 2, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 2, 2022
@r-burns r-burns removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 2, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022
@KAction KAction closed this as completed Dec 7, 2023
@tomodachi94 tomodachi94 added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: static
Projects
None yet
Development

No branches or pull requests

6 participants