Update Io lang to version 2013.12.04 #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| src = fetchurl { | ||
| url = "mirror://sourceforge/polyml/polyml.${version}.tar.gz"; | ||
| sha256 = "514d1d07be487b783d4dfa29dbd550b3396640579ce135a9eb5a61f08e7f9cac"; | ||
| url = "mirror://sourceforge/polyml/polyml.5.5.1.tar.gz"; |
There was a problem hiding this comment.
Repeating the version number here seems unnecessary, no? Why did you remove the version variable?
There was a problem hiding this comment.
Well, I like to be able to download the source with wget or nix-prefetch-url with a single cut and paste.
Also the code is shorter and cleaner this way.
It is true that the version number is repeated twice, but I find it a minor annoyance.
Anyway, in this case is a "mirror://" link, so it doesn't make a real difference.
I just added a commit to reintroduce the version variable.
I don't have a strong opinion on this point.
peti
added a commit
that referenced
this pull request
Jan 17, 2014
Update Io lang to version 2013.12.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.