Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/thelounge: add plugins option #153038

Merged
merged 3 commits into from
Jan 9, 2022
Merged

nixos/thelounge: add plugins option #153038

merged 3 commits into from
Jan 9, 2022

Conversation

winterqt
Copy link
Member

@winterqt winterqt commented Jan 1, 2022 •
edited
Loading

Motivation for this change

The Lounge has support for plugins, so this PR exposes an option in the NixOS module to install them, and adds all of the currently available plugins on NPM to nodePackages (except one).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 1, 2022
@ofborg ofborg bot requested a review from midchildan January 1, 2022 05:36
@winterqt
Copy link
Member Author

winterqt commented Jan 5, 2022

Going to close this while I come up with a better implementation.

@winterqt winterqt closed this Jan 5, 2022
@winterqt winterqt reopened this Jan 8, 2022
@winterqt winterqt force-pushed the thelounge-plugins branch 3 times, most recently from 5d33147 to 9ed9b44 Compare January 8, 2022 22:25
@mweinelt
Copy link
Member

mweinelt commented Jan 9, 2022

Oh, and I'd probably split out the nodePackages changes into a separate commit, out of the module changes. If we would need to revert it things would be very messy right now.

@winterqt winterqt requested a review from mweinelt January 9, 2022 03:49
@winterqt winterqt requested a review from mweinelt January 9, 2022 04:05
@winterqt winterqt requested a review from mweinelt January 9, 2022 18:13
@mweinelt mweinelt merged commit 2499992 into NixOS:master Jan 9, 2022
@winterqt winterqt deleted the thelounge-plugins branch January 29, 2022 01:19
@winterqt winterqt mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winterqt @mweinelt