Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fpp: init at 0.7.1 #15468

Closed
wants to merge 1 commit into from
Closed

fpp: init at 0.7.1 #15468

wants to merge 1 commit into from

Conversation

mpscholten
Copy link
Contributor

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed May 15, 2016
View reviewed changes
pkgs/tools/misc/fpp/default.nix
src = fetchFromGitHub {
owner = "facebook";
repo = "PathPicker";
rev = "refs/tags/${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does rev = version not work? It should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@joachifm joachifm added the 8.has: package (new) This PR adds a new package label May 15, 2016
@joachifm
Copy link
Contributor

Pushed a modified version to master. Thank you.

@joachifm joachifm closed this in 6bbead5 May 15, 2016
@mpscholten mpscholten mentioned this pull request May 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpscholten @joachifm