Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klavaro: 3.01 -> 3.02 #16097

Merged
merged 2 commits into from
Jun 9, 2016
Merged

klavaro: 3.01 -> 3.02 #16097

merged 2 commits into from
Jun 9, 2016

Conversation

mimame
Copy link
Member

@mimame mimame commented Jun 9, 2016

Motivation for this change

Update klavaro to the last version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @vbgl, @peti and @Fuuzetsu to be potential reviewers

@joachifm
Copy link
Contributor

joachifm commented Jun 9, 2016

@mimadrid would you be interested in assuming maintainership of this package?

@mimame
Copy link
Member Author

mimame commented Jun 9, 2016

Of course @joachifm.

@joachifm joachifm merged commit 5890826 into NixOS:master Jun 9, 2016
@joachifm
Copy link
Contributor

joachifm commented Jun 9, 2016

Thank you

@mimame mimame deleted the update/klavaro-3.02 branch June 25, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimame @mention-bot @joachifm