GHC: Split docs #16167
GHC: Split docs #16167
Conversation
|
By analyzing the blame information on this pull request, we identified @peti, @pikajude and @Ericson2314 to be potential reviewers |
|
cc maintainers @MarcWeber @kosmikus @peti |
joachifm
added
6.topic: haskell
6.topic: closure size
|
Is Travis failure relevant to the change? |
|
Travis status isn't really important in this repo, as it has lots of false negatives (unfortunately). |
|
It's the "No rule to make target 'install'" failure, probably spurious. |
| @@ -35,6 +37,7 @@ stdenv.mkDerivation rec { | |||
| "--with-gcc=${stdenv.cc}/bin/cc" | |||
| "--with-gmp-includes=${gmp.dev}/include" "--with-gmp-libraries=${gmp.out}/lib" | |||
| "--with-curses-includes=${ncurses.dev}/include" "--with-curses-libraries=${ncurses.out}/lib" | |||
| "--datadir=$doc/share/doc/ghc" | |||
There was a problem hiding this comment.
--datadir is used for nothing except for the documentation?
There was a problem hiding this comment.
Yes.
rasen@Larry nixpkgs % ls result-doc/share/doc/ghc
html
There was a problem hiding this comment.
According to GHC wiki, docdir defaults to $(prefix)/share/doc/ghc and can be changed with --datadir option (I find this odd, too).
|
This might require some changes to our hoogle support. |
ghcWithHoogle builds with this patch applied, but it's probably still broken in the sense that links might point nowhere or that the generated databases and/or documentation might be incomplete.
|
Yes, @rasendubi, how do we mitigate this issue? |
|
If the paths can't be configured easily, you could try to pass a |
|
@peti I don't have any specific plans yet. Building a vm image with |
The docs were split at NixOS#16167 and broke google support. @peti fixed build, however hoogle still didn't see packages shipped with GHC. This patch fixes location of the libraries shipped with GHC.
|
The hoogle should work fine after #16370 is merged. |
|
Thank you for the quick fix!
|
Motivation for this change
This saves ~168M per GHC installation.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)