nuget-to-nix: sort output not the input #162187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
asmundo
force-pushed
the
nugetToNixSortOutput
branch
from
8546a3e
to
9f9f50a
Compare
|
Idea sounds good but I'm not familiar with nuget2nix.sh |
|
I am dyslexic and it could be that below commit message would be better: |
asmundo
force-pushed
the
nugetToNixSortOutput
branch
from
9f9f50a
to
6ae7250
Compare
|
commit message updated. |
zimbatm
reviewed
Mar 9, 2022
| done < <(find $1 -name '*.nuspec') | ||
|
|
||
| LC_ALL=C sort --ignore-case ${tmpfile} | ||
| rm ${tmpfile} |
There was a problem hiding this comment.
Suggested change
| rm ${tmpfile} |
Not needed anymore with the trap
|
Thank you, this fixes a pretty big issue with #162548 I never noticed :) |
It is the package list output that should be sorted. The current output sequence is not logical because '.' is sorted in front of '/' with input sorting and is not deterministic for different language environments. To get a deterministic and logical sorting in environments with different language configured, env "LC_ALL=C" is set and the produced strings is that is sorted. To get alphabetic sorting and not a pure ASCII value sort "--ignore-case" is added.
asmundo
force-pushed
the
nugetToNixSortOutput
branch
from
6ae7250
to
bbcb7d3
Compare
13 tasks
| @@ -8,6 +8,8 @@ if [ $# -eq 0 ]; then | |||
| fi | |||
|
|
|||
| pkgs=$1 | |||
| tmpfile=$(mktemp /tmp/nuget-to-nix.XXXXXX) | |||
| trap 'rm -f "$tmpfile" EXIT | |||
There was a problem hiding this comment.
It looks like a quote was missed here, breaking the program: nuget-to-nix: line 25: unexpected EOF while looking for matching ''
Suggested change
| trap 'rm -f "$tmpfile" EXIT | |
| trap 'rm -f "$tmpfile"' EXIT |
13 tasks
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the package list output that should be sorted. The file input
sorting do not produce stable output lists.
Motivation for this change
Sorting of input files do not produce stable output list across machines with version changes for some reason.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes