Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen: 4.3.1 -> 4.4.0 #16378

Merged
merged 1 commit into from
Jun 21, 2016
Merged

screen: 4.3.1 -> 4.4.0 #16378

merged 1 commit into from
Jun 21, 2016

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented Jun 20, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Removed the patches which were specific to 4.3, and redundant configure flags

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @rycee, @peti and @aespinosa to be potential reviewers

Removed the patches which were specific to 4.3, and redundant configure flags
The darwin specific utmp patch seems to have been accepted too, with
`u->ut_time = now` the default.
@gebner gebner added the 8.has: package (update) This PR updates a package to a newer version label Jun 21, 2016
@gebner gebner merged commit e5740b2 into NixOS:master Jun 21, 2016
@gebner
Copy link
Member

gebner commented Jun 21, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants