Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.uvloop: disable problematic test on armv7l too #177398

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jun 12, 2022

Description of changes

Fix build on armv7l.
Related: #122297

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • armv7l-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jun 12, 2022
@misuzu misuzu requested a review from mweinelt June 12, 2022 13:20
@mweinelt
Copy link
Member

You can repro the exact issue on armv7? Fancy. Which hardware?

@misuzu
Copy link
Contributor Author

misuzu commented Jun 12, 2022

@mweinelt I'm using Oracle Cloud aarch64 VM with personality patch from Ubuntu: #25240 (comment)

@mweinelt mweinelt merged commit 07bf3d2 into NixOS:master Jun 12, 2022
@misuzu misuzu deleted the uvloop-armv7l branch June 12, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants