Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quassel: Add a package option #20159

Merged
merged 1 commit into from
Nov 4, 2016
Merged

quassel: Add a package option #20159

merged 1 commit into from
Nov 4, 2016

Conversation

uwap
Copy link
Contributor

@uwap uwap commented Nov 4, 2016

Motivation for this change

There are packages for quassel with qt4 and qt5 because quassel and KDE don't work together with qt5. For a server application this is irrelevant if you have a server that deploys a quassel daemon. A qt5 version can has advantages so it should be up to the user what package should be used.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@uwap, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Phreedom, @Shados and @peti to be potential reviewers.

@Profpatsch Profpatsch merged commit d9134dd into NixOS:master Nov 4, 2016
@Profpatsch
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants