Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acpid doesn't pass event text to event handlers #21557

Closed
ToxicFrog opened this issue Dec 31, 2016 · 1 comment · Fixed by #34190
Closed

acpid doesn't pass event text to event handlers #21557

ToxicFrog opened this issue Dec 31, 2016 · 1 comment · Fixed by #34190

Comments

@ToxicFrog
Copy link
Contributor

If you define a handler with acpid.handlers.foo.action, it writes the acpid config file using echo "action=${...contents of handler...}" >> $fn. This drops all information about the ACPI event on the floor. It should instead use echo "action=${...contents of handler...} '%e'" >> $fn in order to pass the text of the event to the handler.
@Mic92
Copy link
Member

Mic92 commented Jan 2, 2017

Do you want make a pull request? Actually I would also use writeShellScript in this file instead of writeScript.

JohnAZoidberg added a commit to JohnAZoidberg/nixpkgs that referenced this issue Jan 23, 2018
@JohnAZoidberg
nixos/acpid: pass event parameters to handler
81a8e2e 
Previously the parameters were just dropped. Now they can be read
from within the handler script. An example to show this is added.

Makes use of the new writeShellScript function as suggested in:
issue NixOS#21557

resolves:  NixOS#21557
@JohnAZoidberg JohnAZoidberg mentioned this issue Jan 23, 2018
Merged
8 tasks
Mic92 pushed a commit that referenced this issue Feb 10, 2018
@JohnAZoidberg @Mic92
nixos/acpid: pass event parameters to handler (#34190)
713a69d 
Previously the parameters were just dropped. Now they can be read
from within the handler script. An example to show this is added.

Makes use of the new writeShellScript function as suggested in:
issue #21557

resolves:  #21557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nixos/acpid: pass event parameters to handler JohnAZoidberg/nixpkgs
2 participants
@ToxicFrog @Mic92