Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: update yi to 0.8.1 #2230

Merged
merged 1 commit into from
Apr 12, 2014
Merged

haskell: update yi to 0.8.1 #2230

merged 1 commit into from
Apr 12, 2014

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Apr 12, 2014

No description provided.

];
buildTools = [ alex ];
configureFlags = "-fpango";
jailbreak = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, everything builds without jailbreaking now? I know @peti tends to keep jailbreaks in (though I disagree with that).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tests still don't run though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your reasons for wanting to remove jailbreaks?

I know we talked about this a while ago, but now I feel like I don't remember any more what your rationale was, which is a good indication that I probably didn't fully understand them at the time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fact that I'm running un-altered source as much as possible, that I can report real problems upstream and help contribute to Hackage in general, and also there may be subtle bugs with jailbreaking, when type classes change their meaning (though we haven't really observed that problem yet).

You replied by saying "if it broke once it might break again", which is of course true. On the other hand, we seem to break Haskell packaging on master fairly frequently anyway (for example, we updated authenticate-oauth, which still doesn't build until upstream resolve some issues).

ocharles added a commit that referenced this pull request Apr 12, 2014
haskell: update yi to 0.8.1
@ocharles ocharles merged commit d64fdcc into NixOS:master Apr 12, 2014
@bennofs bennofs deleted the update-yi branch April 12, 2014 21:09
@bennofs
Copy link
Contributor Author

bennofs commented Apr 18, 2014

There seems to be an issue with haddock: http://hydra.nixos.org/build/10405775/nixlog/1/raw

@falsifian
Copy link
Contributor

@bennofs I just successfully compiled haskellPackages_ghc782.yi at master (149105a). So maybe it's a ghc bug that got fixed by GHC 7.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants