Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind: enable DIG_SIGCHASE (fix #10728) #22989

Closed
wants to merge 1 commit into from

Conversation

FlorentBecker
Copy link
Contributor

Motivation for this change

See #10728

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@FlorentBecker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @fpletz and @edolstra to be potential reviewers.

@vcunat
Copy link
Member

vcunat commented Feb 19, 2017

I don't think it works, as it should accept +sigchase but still doesn't. (I tested it does work on Ubuntu.)

$ ./result-dnsutils/bin/dig @dns102.comcast.net. dnssec-failed.org +dnssec +sigchase
Invalid option: +sigchase
...

@abbradar
Copy link
Member

I think it should be set before ./configure, so just:

  STD_CDEFINES = [ "-DDIG_SIGCHASE=1" ];

instead of postConfigure should do the job.

@vcunat vcunat closed this in f1e7a60 Feb 19, 2017
@vcunat
Copy link
Member

vcunat commented Feb 19, 2017

Thanks. Nice feature, at a cursory look. Proliferation of DNSSEC support is part of my paid job :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants