wrapFirefox: fix default-browser update #23516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set MOZ_APP_LAUNCHER for firefox as per [1] (see [2] for detailed discussion). Firefox will recognise itself across verions, skipping the 'not-the-default-browser' prompt. Firefox will also write sane paths to the generated desktop file, should someone ever set it as default through the 'not-the-default-browser' prompt. Also removed the unnecessary libtrick cruft. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=611953 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=593948
7c6f434c
approved these changes
Mar 5, 2017
|
You did test execution of the wrapper too, right? |
|
I tested all the wrappers rebuilt by nox-review. |
|
shouldn't this go o 17.03 as well? @globin |
|
cherry-picked |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set MOZ_APP_LAUNCHER for firefox as per [1] (see [2] for detailed discussion).
Firefox will recognise itself across verions, skipping the 'not-the-default-browser' prompt.
Firefox will also write sane paths to the generated desktop file, should someone ever set it as default through the 'not-the-default-browser' prompt.
Also removed the unnecessary libtrick cruft.
This fixes #4370 for firefox.
/cc @vcunat
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=611953
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=593948